fix: Invoice report title in message preview shows an incorrect report title by suhailpthaj · Pull Request #78992 · Expensify/App

suhailpthaj · 2026-01-07T11:29:24Z

Explanation of Change

fix:

Incorrect report title in the Header of Chat thread of Invoice report (In Reports > Chats).
Incorrect title in the RHP of Chat thread details page which opens up when clicked on the Chat thread header.
Incorrect subtitle in the Room members RHP, when open, by selecting the Members option in Chat thread details page.
Incorrect title in Share code when click on Share on Chat thread details page.

Fixed Issues

$ #75857
PROPOSAL: #75857 (comment)

Tests

Precondition: You must have the workspace with invoices enabled.

Login to the app.
Click on FAB then click on Send invoice option.
Enter the amount.
Choose, to whom, you want to send the invoice.
Click on Send invoice, (Enter 'your name' and 'your company name' if asked).
Navigate to invoice room.
Click on the invoice report.
Send a message in the invoice report.
Navigate to Reports > Chats.
Click on the chat of the invoice.
Verify that the report title in the header matches the actual invoice report title and subtitle shows the correct subtitle along with the status badge.
Click on the title which navigates to the report details page.
Verify that the title on report details page matches the actual invoice report title instead of Amount expense.
In Report details page, click on Members.
Verify that the subtitle, near the Members, matches the actual invoice report title instead of Amount expense.
On Report details page, click on Share.
Verify that the title beneath the QR code matches the actual invoice report title instead of Amount expense.

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android-native.mp4

Android: mWeb Chrome

Android-mWeb.mp4

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…t title

melvin-bot · 2026-01-07T11:29:31Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2026-01-07T11:29:34Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

suhailpthaj · 2026-01-07T11:30:10Z

I have read the CLA Document and I hereby sign the CLA

mananjadhav · 2026-01-07T20:31:51Z

Reviewing this proposal.

suhailpthaj · 2026-01-09T11:57:43Z

@mananjadhav @JmillsExpensify Any update on this PR?

mananjadhav · 2026-01-10T18:53:14Z

    const isReportArchived = useReportIsArchived(report.reportID);
+    const [parentReport] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${report?.parentReportID}`, {canBeMissing: true});
+    // Calculating the report title with parent report if parent report is invoice and current report is chat thread.
+    const isParentInvoiceAndIsChatThread = useMemo(() => isChatThread(report) && isInvoiceReport(parentReport), [report, parentReport]);


This seems repititive? Can we move this to a util please?

Done.

Moved the repetitive logic from RoomMembersPage, ShareCodePage and ReportDetailsPage to a util function getReportForDisplay.

mananjadhav · 2026-01-10T18:55:31Z

    const title = getReportName(reportHeaderData, policy, parentReportAction, personalDetails, invoiceReceiverPolicy, undefined, undefined, isReportHeaderDataArchived);
    const subtitle = getChatRoomSubtitle(reportHeaderData, false, isReportHeaderDataArchived);
+    // This is used to get the status badge for invoice report subtitle.
+    const statusTextForInvoiceReport = isParentInvoiceAndIsChatThread ? getReportStatusTranslation({stateNum: reportHeaderData?.stateNum, statusNum: reportHeaderData?.statusNum, translate}) : undefined;


Can you highlight the need for this change please?

We need this code in HeaderView to get the status badge for invoice report. I've pointed the status badge in the given image.

mananjadhav · 2026-01-13T17:14:52Z

+ * For invoice chat threads, returns the parent invoice report.
+ * For other cases, returns the provided report.
+ */
+function getReportForDisplay(report: OnyxEntry<Report>): OnyxEntry<Report> {


Should we name this as getReportForHeader? Considering that's what we're using it for?

This will be done till 12:15 pm IST. I'll notify here.

mananjadhav · 2026-01-13T17:15:50Z

@suhailpthaj The revised changes look fine. Last one comment, and I'll work on the checklist. Can you please sync the latest main and resolve conflicts?

…icts and merged main

suhailpthaj · 2026-01-13T18:07:05Z

@mananjadhav Synced the latest main and Resolved the merge conflicts.

mananjadhav

2 more comments.

mananjadhav · 2026-01-13T18:09:08Z

    const isPolicyExpenseChat = useMemo(() => isPolicyExpenseChatUtils(report), [report]);
    const backTo = route.params.backTo;
    const isReportArchived = useReportIsArchived(report.reportID);
+    const reportForSubtitle = useMemo(() => getReportForHeader(report), [report]);


May be I missed earlier, we defined this but I don't see it being used?

mananjadhav · 2026-01-13T18:25:01Z

    const isTaskReport = isTaskReportReportUtils(report);
-    const reportHeaderData = !isTaskReport && !isChatThread && report?.parentReportID ? parentReport : report;
+    // This is used to check if the report is a chat thread and has a parent invoice report.
+    const isParentInvoiceAndIsChatThread = isChatThread && !!parentReport && isInvoiceReport(parentReport);


Possible to simplify this to use util?

I though this too to move in util but this has another logic too to decide whether to pick the parent report or not and I didn't want to break anything that's why I left HeaderView as it is.

Even if we move this to util then we do need isParentInvoiceAndIsChatThread here as there are two factors to decide whether to pick the parent report or not in HeaderView, other locations has only one.

mananjadhav · 2026-01-13T18:52:03Z

Testing the changes now.

mananjadhav · 2026-01-14T16:33:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-invoice-title.mov

Android: mWeb Chrome

mweb-chrome-invoice-title.mov

iOS: HybridApp

ios-invoice-title.mov

iOS: mWeb Safari

mweb-safari-invoice-title.mov

MacOS: Chrome / Safari

web-invoice-title.mov

mananjadhav · 2026-01-14T16:49:06Z

@Beamanator @JmillsExpensify All yours.

codecov · 2026-01-14T19:13:49Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/libs/ReportUtils.ts	`71.66% <100.00%> (+<0.01%)`	⬆️
src/pages/ReportDetailsPage.tsx	`56.68% <75.00%> (+0.08%)`	⬆️
src/pages/home/HeaderView.tsx	`85.61% <83.33%> (-0.20%)`	⬇️
src/pages/RoomMembersPage.tsx	`0.00% <0.00%> (ø)`
src/pages/ShareCodePage.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

suhailpthaj · 2026-01-16T09:38:07Z

@Beamanator @JmillsExpensify Bump for PR review.

In the latest commit, I only resolved merge conflicts and fixed prettier formatting. IMO, the code looks good now.

Beamanator · 2026-01-16T15:37:35Z

@JmillsExpensify wanna do a review before me? 🙏

mananjadhav · 2026-01-19T11:52:20Z

Quick bump on this @JmillsExpensify @Beamanator

JmillsExpensify

All good on the product side. Apologies for the delay!

Beamanator

LGTM!

OSBotify · 2026-01-19T21:48:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-20T17:41:35Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 9.3.5-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2026-01-21T23:06:04Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.3.5-7 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Invoice report title in message preview shows an incorrect repor…

6573442

…t title

suhailpthaj requested review from a team as code owners January 7, 2026 11:29

melvin-bot Bot assigned suhailpthaj Jan 7, 2026

melvin-bot Bot requested review from JmillsExpensify and mananjadhav and removed request for a team January 7, 2026 11:29

melvin-bot Bot removed the request for review from a team January 7, 2026 11:29

CLABotify added a commit to Expensify/CLA that referenced this pull request Jan 7, 2026

@suhailpthaj has signed the CLA in Expensify/App#78992

12c7d3e

Resolved merge conflicts

3d107d8

mananjadhav reviewed Jan 10, 2026

View reviewed changes

Added a utility to get the report to display title

95f0a45

mananjadhav reviewed Jan 13, 2026

View reviewed changes

Renamed 'getReportForDisplay' to 'getReportForHeader', Resolved confl…

f88dbd0

…icts and merged main

mananjadhav reviewed Jan 13, 2026

View reviewed changes

replace report with reportForSubtitle in RoomMembersPage

8b29ced

mananjadhav approved these changes Jan 14, 2026

View reviewed changes

melvin-bot Bot requested a review from Beamanator January 14, 2026 16:48

Fixed prettier formatting and resolved merge conflicts

7eed111

JmillsExpensify approved these changes Jan 19, 2026

View reviewed changes

Beamanator approved these changes Jan 19, 2026

View reviewed changes

Beamanator merged commit 3db611f into Expensify:main Jan 19, 2026
30 checks passed

OSBotify mentioned this pull request Jan 20, 2026

Deploy Checklist: New Expensify 2026-01-20 #80009

Closed

85 tasks

Conversation

suhailpthaj commented Jan 7, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Jan 7, 2026

Uh oh!

github-actions Bot commented Jan 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

suhailpthaj commented Jan 7, 2026

Uh oh!

mananjadhav commented Jan 7, 2026

Uh oh!

suhailpthaj commented Jan 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mananjadhav Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suhailpthaj Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Jan 13, 2026

Uh oh!

suhailpthaj commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mananjadhav commented Jan 13, 2026

Uh oh!

mananjadhav commented Jan 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav commented Jan 14, 2026

Uh oh!

codecov Bot commented Jan 14, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

suhailpthaj commented Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Beamanator commented Jan 16, 2026

Uh oh!

mananjadhav commented Jan 19, 2026

Uh oh!

JmillsExpensify left a comment

github-actions Bot commented Jan 7, 2026 •

edited

Loading

mananjadhav Jan 13, 2026 •

edited

Loading

suhailpthaj Jan 13, 2026 •

edited

Loading

suhailpthaj commented Jan 13, 2026 •

edited

Loading

mananjadhav commented Jan 14, 2026 •

edited

Loading

codecov Bot commented Jan 14, 2026 •

edited by github-actions Bot

Loading

suhailpthaj commented Jan 16, 2026 •

edited

Loading